Skip to content

Algebraic kernel d performance efif - #9882

Open
efifogel wants to merge 3 commits into
CGAL:mainfrom
efifogel:Algebraic_kernel_d-performance-efif
Open

efifogel wants to merge 3 commits into
CGAL:mainfrom
efifogel:Algebraic_kernel_d-performance-efif

Conversation

@efifogel

Copy link
Copy Markdown
Member

Summary of Changes

Skipped a redundant content computation in Decompose_2

Decompose_2 computed the univariate content of the cached gcd of the two curves on every call, although it is needed only when the gcd has degree 0 in y, in which case it is the only coefficient of the gcd.

I kept changes to a minimum.

Release Management

  • Affected package(s): Algebraic_kernel_d
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: Unchanged

Curve_analysis_2::status_line_of_interval() constructed an algebraic real
from the rational value of the interval before looking up the cached
status line; it now looks it up by the rational value first.
Decompose_2 computed the univariate content of the cached gcd of the two
curves on every call, although it is needed only when the gcd has degree 0
in y, in which case it is the only coefficient of the gcd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant