Repository navigation
Conversation
Curve_analysis_2::status_line_of_interval() constructed an algebraic real from the rational value of the interval before looking up the cached status line; it now looks it up by the rational value first.
Decompose_2 computed the univariate content of the cached gcd of the two curves on every call, although it is needed only when the gcd has degree 0 in y, in which case it is the only coefficient of the gcd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Skipped a redundant content computation in Decompose_2
Decompose_2computed the univariate content of the cached gcd of the two curves on every call, although it is needed only when the gcd has degree 0 iny, in which case it is the only coefficient of the gcd.I kept changes to a minimum.
Release Management